server-side-rendering error handling

express should not be crushed even if server-side-rendering occurs an error.

server-side-rendering error handling
aa3e1abb · Seongjun Kim · 7a932e9f · aa3e1abb
Commit aa3e1abb authored Oct 22, 2016 by Seongjun Kim
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

server.js server.js +4 -3

No files found.
--- a/server.js
+++ b/server.js
@@ -59,10 +59,9 @@ app.get('*', (req, res) => {
  const renderStream = renderer.renderToStream(context)
  let firstChunk = true

-  res.write(html.head)
-
  renderStream.on('data', chunk => {
    if (firstChunk) {
+      res.write(html.head)
      // embed initial store state
      if (context.initialState) {
        res.write(
@@ -82,7 +81,9 @@ app.get('*', (req, res) => {
  })

  renderStream.on('error', err => {
-    throw err
+    // Render Error Page or Redirect
+    res.status(500).end('Internal Error 500')
+    console.error(`error during render : ${req.url}`)
  })
 })